fix: Use alternative logout url for oauth2#1182
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 41 41
Lines 2566 2568 +2
=======================================
+ Hits 2426 2428 +2
Misses 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| response.headers.get("X-Auth-Request-Redirect") | ||
| == oidc_config.end_session_endpoint | ||
| response.headers.get("location") | ||
| == "/oauth2/logout/https%3A%2F%2Fexample.com%2Fend_session" |
Contributor
There was a problem hiding this comment.
Suggested change
| == "/oauth2/logout/https%3A%2F%2Fexample.com%2Fend_session" | |
| == oidc_config.end_session_endpoint + "/https%3A%2F%2Fexample.com%2Fend_session" |
Contributor
Author
There was a problem hiding this comment.
I just wanted to see the actual url being generated
DiamondJoseph
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it is sending the request to the oauth2-proxy but is not redirecting blueapi to the Identity provider so I will give this a try with the other method in oauth2-proxy docs.